Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better logging and smarter behaviour for drop invalid mappings #233

Merged
merged 12 commits into from
Oct 16, 2024
Merged

better logging and smarter behaviour for drop invalid mappings #233

merged 12 commits into from
Oct 16, 2024

Conversation

ix0rai
Copy link
Member

@ix0rai ix0rai commented Oct 15, 2024 •
edited
Loading

  • add a test for drop invalid mappings
  • add better logging for drop invalid mappings
  • improved dropping behaviour
    • drop methods that have no mapping and only invalid parameters

TODO:

  • fix out-of-bounds parameters not being dropped

@ix0rai ix0rai added enhancement New feature or request backend affects the enigma backend cli affects the enigma command-line interface labels Oct 15, 2024
@ix0rai ix0rai marked this pull request as ready for review October 16, 2024 01:05
@ix0rai ix0rai requested a review from IotaBread October 16, 2024 01:05
IotaBread
IotaBread reviewed Oct 16, 2024
View reviewed changes
enigma/src/main/java/org/quiltmc/enigma/api/analysis/index/jar/EntryIndex.java Outdated Show resolved Hide resolved
enigma/src/main/java/org/quiltmc/enigma/api/analysis/index/jar/EntryIndex.java Outdated Show resolved Hide resolved
enigma/src/main/java/org/quiltmc/enigma/impl/translation/mapping/MappingsChecker.java Show resolved Hide resolved
enigma-cli/src/test/resources/drop_invalid_mappings/expected/EmptyMappings.mapping Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this file be deleted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i prefer having the expected result stored in a file instead of hardcoded. idk

@ix0rai ix0rai merged commit ba80b7e into QuiltMC:master Oct 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IotaBread IotaBread IotaBread left review comments

Assignees
No one assigned
Labels
backend affects the enigma backend cli affects the enigma command-line interface enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ix0rai @IotaBread