Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact Us and Report Problem Forms #955

Merged
merged 2 commits into from
Apr 13, 2021
Merged

Contact Us and Report Problem Forms #955

merged 2 commits into from
Apr 13, 2021

Conversation

Allcharles
Copy link
Collaborator

@Allcharles Allcharles commented Mar 28, 2021

Contact Us and Report Problem Forms

Setup and implemented contact us and report problem forms.

Changes

  • Created BawApiFormService to handle non-official baw-server API endpoints
  • Created ContactUsService and ReportProblemService
  • Updated registration form to have better error reporting
  • Hopefully fixes issue with dependabot PRs crashing

Problems

  • Forms still dont entirely work as the recaptcha token is invalid. Waiting on @atruskie to get back to try diagnose the issue
  • Have not created tests for ContactUs and ReportProblem forms

Issues

Final Checklist

  • Assign reviewers if you have permission
  • Assign labels if you have permission
  • Link issues related to PR
  • Ensure project linter is not producing any warnings (npm run lint)
  • Ensure build is passing on all browsers (npm run test:all)
  • Ensure CI build is passing
  • Ensure docker container is passing (docs)

@Allcharles Allcharles added architecture Architectural changes to the software enhancement New feature or request labels Mar 28, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2021

Size Change: +18.2 kB (+1%)

Total Size: 1.24 MB

Filename Size Change
dist/workbench-client/browser/index.html 1.04 kB +1 B (0%)
dist/workbench-client/browser/main-es2015.********************.js 562 kB +9.03 kB (+2%)
dist/workbench-client/browser/main-es5.********************.js 587 kB +9.12 kB (+2%)
ℹ️ View Unchanged
Filename Size Change
dist/workbench-client/browser/assets/environment.json 401 B 0 B
dist/workbench-client/browser/manifest.json 150 B 0 B
dist/workbench-client/browser/polyfills-es2015.********************.js 12.6 kB 0 B
dist/workbench-client/browser/polyfills-es5.********************.js 46.2 kB 0 B
dist/workbench-client/browser/runtime-es2015.********************.js 719 B 0 B
dist/workbench-client/browser/runtime-es5.********************.js 719 B 0 B
dist/workbench-client/browser/styles.********************.css 27.2 kB 0 B

compressed-size-action

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@Allcharles Allcharles marked this pull request as ready for review April 12, 2021 07:07
- Created and implemented report services
- Update models to use new generic
- Implemented recaptcha seed functions
- Setup error notification on invalid recaptcha token
- Validate username and email for register form
- Modify form subTitle handling
- Use library for http-codes
- Re-organise eslint field
- Added lint rule for deprecated imports
@github-actions
Copy link
Contributor

Unit Test Results

         6 files           6 suites   7m 39s ⏱️
13 542 tests 12 966 ✔️ 576 💤 0 ❌
13 548 runs  12 972 ✔️ 576 💤 0 ❌

Results for commit 12c1e18.

@Allcharles Allcharles merged commit 85a25ea into master Apr 13, 2021
@Allcharles Allcharles deleted the report-forms branch April 13, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Architectural changes to the software enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants