Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kratos subject webhook endpoint #945

Open
wants to merge 28 commits into
base: feature/ory-based-authorization
Choose a base branch
from
Open

Add kratos subject webhook endpoint #945

wants to merge 28 commits into from

Conversation

mpgxvii
Copy link
Member

@mpgxvii mpgxvii commented Aug 28, 2024 •
edited
Loading

Description:

  • Add kratos webhook endpoint to allow automatic creation of subjects after kratos registration
  • After subject is created, this adds back session id information such as scope, roles, to kratos id
  • Separate out subject, admin, and researcher identities

Solves https://github.com/RADAR-base/hydra-kratos/issues/43

@mpgxvii mpgxvii mentioned this pull request Aug 28, 2024
Closed
@mpgxvii mpgxvii marked this pull request as ready for review September 13, 2024 13:46
Base automatically changed from feat/hydra-token to feature/ory-based-authorization September 13, 2024 13:53
@mpgxvii
Merge branch 'feature/ory-based-authorization' of https://github.com/…
632052c 
…RADAR-base/ManagementPortal into feat/kratos-endpoint
@mpgxvii
Merge branch 'minor-fixes' of https://github.com/RADAR-base/Managemen…
b5f63b3 
…tPortal into feat/kratos-endpoint
@mpgxvii
Add specify project user id when creating subject
c4ff72f
@mpgxvii
Update Project class to include user id
30ac797
@mpgxvii
Update subject activation endpoint to use project user id
580959c
@mpgxvii
Merge branch 'feature/ory-based-authorization' of https://github.com/…
932f131 
…RADAR-base/ManagementPortal into feat/kratos-endpoint
@mpgxvii
Update Authservice and LoginEndpoint configs
fcfe271
@mpgxvii
Refactor IdentityService to remove similar methods
968dae8
@mpgxvii
Add support for updating identity server with changes in Subject and …
a18bc56 
…User in MP
@mpgxvii
Rename userService method
ac468e4
@mpgxvii
Save identity id when creating user
a203098
yatharthranjan
yatharthranjan reviewed Nov 26, 2024
View reviewed changes
Copy link
Member

@yatharthranjan yatharthranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some comments below.

src/main/java/org/radarbase/management/service/IdentityService.kt Show resolved Hide resolved
src/main/java/org/radarbase/management/service/SubjectService.kt Show resolved Hide resolved
src/main/java/org/radarbase/management/service/SubjectService.kt Show resolved Hide resolved
src/main/java/org/radarbase/management/service/dto/UserDTO.kt Show resolved Hide resolved
src/main/java/org/radarbase/management/web/rest/KratosEndpoint.kt Show resolved Hide resolved
src/main/java/org/radarbase/management/web/rest/KratosEndpoint.kt
EntityName.PROJECT,
"projectNotFound"
)
val subjectDto =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if possible, try to get the ID from the admin endpoint on kratos and verify with the one in the post request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yatharthranjan yatharthranjan yatharthranjan left review comments

@nivemaham nivemaham Awaiting requested review from nivemaham

@Bdegraaf1234 Bdegraaf1234 Awaiting requested review from Bdegraaf1234

@peyman-mohtashami peyman-mohtashami Awaiting requested review from peyman-mohtashami peyman-mohtashami is a code owner

@pvannierop pvannierop Awaiting requested review from pvannierop pvannierop is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpgxvii @yatharthranjan