Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spatial search requests refactor #101

Merged

Conversation

jamiefeiss
Copy link
Collaborator

Updates CatPrezMapSearch.vue & SpacePrezMapSearch.vue to use the new API request composables.

Any SPARQL queries that can be replaced by API calls have been replaced, such as getting the list of catalogs, datasets & feature collections. Some of the data structures have been updated, as well as the remaining SPARQL queries, but the functionality of both components remain unchanged. The Pinia stores used for requests are no longer needed, and can be removed.

Copy link
Collaborator

@edmondchuc edmondchuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Search seems to work fine, but it no longer does a zoom in to show the geometries found in the spatial map search.
Screenshot 2023-08-30 at 3 46 54 pm

Copy link
Collaborator

@edmondchuc edmondchuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamiefeiss jamiefeiss merged commit d48a8c3 into feature/api-requests-refactor Sep 4, 2023
1 check passed
@jamiefeiss jamiefeiss deleted the feature/mapsearch-requests-refactor branch September 4, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants