merge lawson/label_predicates into maintenance-v3 #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recalcitrantsupplant
requested changes
Oct 4, 2024
There was a problem hiding this comment.
Looks fine but can you change root_validator to field_validator
https://docs.pydantic.dev/latest/migration/#validator-and-root_validator-are-deprecated
|
actually, looks like field_validator is only introduced in Pydantic version 2. Prez v3 is still on Pydantic v1 |
recalcitrantsupplant
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small fix to allow setting of labelling predicates via environment variable.