Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprioritise Alternates Profile #280

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

recalcitrantsupplant
Copy link
Collaborator

You will now only get the alternates profile if you specifically request it. Otherwise if any other profile is available, you'll get that. This will prevent unintended behaviour in the UI where the Alternates Profile was equally "ranked" with another profile, so either could be returned on page refresh.

@recalcitrantsupplant
Copy link
Collaborator Author

@hjohns fyi

Copy link
Collaborator

@lalewis1 lalewis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@recalcitrantsupplant recalcitrantsupplant merged commit 71798f8 into main Oct 16, 2024
2 checks passed
@recalcitrantsupplant recalcitrantsupplant deleted the david/deprioritise-alt-prof branch October 16, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants