Allow authenticated users to generate tokens via the UI #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I made this addition to the module to make it easier for users to get a token for the API.
e0ipso
requested changes
Mar 14, 2018
| * @param array $form_state | ||
| * The form state array. | ||
| */ | ||
| function restful_token_auth_generate_token_form_validate($form, &$form_state) { |
| */ | ||
| function restful_token_auth_generate_token_form($form, &$form_state, $uid) { | ||
| $form['description'] = array( | ||
| '#markup' => t('<p>You don\'t have an API key yet. Click below to generate one.</p>'), |
There was a problem hiding this comment.
Let's avoid markup in the translation string. Maybe consider #prefix and #suffix for this.
| <p>Your authentication token is: <code><?php print $token; ?></code></p> | ||
|
|
||
| <p>Discover the API by running the following command in a terminal and replacing | ||
| [your-token] by the above string:</p> |
There was a problem hiding this comment.
I don't see [your-token] anywhere. Maybe it's a stale comment?
|
|
||
| <p> | ||
| <code> | ||
| curl -H 'access-token:<?php print $token; ?>' <?php print $GLOBALS['base_url'] ?>/api?all=true |
There was a problem hiding this comment.
Maybe it's better to have a preprocess function that uses url(…) to set up a variable. Then we only need to print the variable here. The current code will fail if the site is installed in a subdir, or there is a language path prefix, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made this addition to the module to make it easier for users to get a token for the API.
Here is what a user would see at its profile:
And then, after generating the token: