Setting sub_property on the entity #1031
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AronNovak
commented
Jun 21, 2018
| $wrapper->{$property_name}->set($field_value); | ||
| } | ||
| else { | ||
| $wrapper->{$property_name}->{$sub_property}->set($field_value); |
There was a problem hiding this comment.
@amitaibu is it correct or is it supposed to be handled on a higher level?
|
@amitaibu should i create another issue to fix Travis there? Does it worth? |
|
Yes, I'd be happy to see a working Travis. |
|
@amitaibu now with green Travis |
|
@amitaibu This is green, but I absolutely dislike the way how it's done, however at the project we need it, it does the job for the address field and it does not break tests there either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1030
Status
Addresses can be created with this patch, without that, the error in the issue appears.
