Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

08-interop/task03: Just use premade binary #306

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Conversation

MrKevinWeiss
Copy link
Contributor

I think my git tracking messed up so this is not based on my branch... Anyways it just ran locally and worked.

$ tox -e test -- -k "spec08 and task03"
=============================================== test session starts ===============================================
platform linux -- Python 3.10.12, pytest-7.3.2, pluggy-1.4.0 -- /home/weiss/repos/Release-Specs/.tox/test/bin/python
cachedir: .tox/test/.pytest_cache
rootdir: /home/weiss/repos/Release-Specs
configfile: setup.cfg
plugins: cov-5.0.0, rerunfailures-14.0
collected 136 items / 135 deselected / 1 selected                                                                 

08-interop/test_spec08.py::test_task03[nodes0] PASSED                                                       [100%]

----------------------- generated xml file: /home/weiss/repos/Release-Specs/test-report.xml -----------------------
================================== 1 passed, 135 deselected in 80.25s (0:01:20) ===================================
  test: OK (81.09=setup[0.05]+cmd[81.04] seconds)
  congratulations :) (81.15 seconds)

@MrKevinWeiss
Copy link
Contributor Author

@Teufelchen1
Copy link
Contributor

Linter ist not happy

Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After #309 has been merged, the pylint CI should pass now after a rebase. @MrKevinWeiss do you want me to pick this up?

08-interop/test_spec08.py Show resolved Hide resolved
Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thanks for explaining! LGTM then :)

@mguetschow mguetschow merged commit 694ca38 into master Jun 24, 2024
3 checks passed
@mguetschow mguetschow deleted the pr/fix/contikisetup branch June 24, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants