-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
murdock-worker: bump git-cache-rs to 0.1.5 #244
Conversation
Please rebase onto #246 (or master once that is in), that should make the problem go away. |
1a91abb
to
a13237a
Compare
huh, this was rebased, it still shows |
/me facepalms The 2024.01 release did not yet get the riot-sys fix. On the "how do we make sure this doesn't happen again" side, I've added a check point to the release check list that'll flag when there are pending commits on riot-sys/-wrappers. On the "what do we do now" side ... can we backport 002cd42e26e7fbc3140e9d7aa5a1788bfa9f70f9? Even if we don't do a point release (we rarely do), this makes sure the fix winds up on the branch that gets pulled. (I'd PR it myself, but the backport script doesn't work for people whose RIOT clone is not in their user repo). |
I guess so. |
so which PR is that? |
Or should it just be the one commit? |
I would probably do a point release, maybe after a week if everything is stable. |
While you're here - would you give this an ACK? It's been tested quite a bit on ci-staging.riot-os.org. |
a13237a
to
1e878e5
Compare
When the initial
git cache clone
would have a commit specified (--commit HASH
), and would trigger the initial clone into the cache directory, the final "checkout HASH" was skipped.This caused the first dwq worker thread to checkout a branch to fail every job with
./.murdock: not found
.kaspar030/git-cache-rs@0.1.3...0.1.5