shell: change XFA format for !20958 #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
commented
Nov 6, 2024
src/shell/mod.rs
Outdated
Comment on lines
436
to
437
| #[link_section = ".roxfa.shell_commands_xfa.5"] | ||
| #[export_name = concat!("shell_commands_xfa_5_", stringify!($modname))] |
There was a problem hiding this comment.
Doing this backward compatible would probably require some cooperation from RIOT. I guess changing the XFA section name (e.g. from .roxfa.shell_commands_xfa.5 to .roxfa.shell_commands_v2_xfa.5) and providing both ptr and element would work, assuming that the linker would garbage collect the ptr in the newer version.
There was a problem hiding this comment.
That seems to indeed just work
There was a problem hiding this comment.
The garbage collection does not work here, so while this does allow adding shell commands in a way that works with both pre and post !20958 RIOT, it will not reduce the overhead.
I guess this is acceptable mid-term? We could drop the ptr for backward compatibility in the long run.
maribu
force-pushed
the
fix-riot-pr20958
branch
from
5b5e1db
to
b8eaa41
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See RIOT-OS/RIOT#20958