Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Acknowledge all available periph_uart variations #137

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Conversation

chrysn
Copy link
Member

@chrysn chrysn commented Nov 29, 2024

The list is extracted from RIOT's makefiles.

This is not useful on its own, but it is correct in the sense that those are valid cfgs (any RIOT module name is), and it may make the difference between #39 merges not building and building.

@chrysn chrysn enabled auto-merge November 29, 2024 17:19
@chrysn chrysn merged commit 1fa4917 into main Nov 29, 2024
81 checks passed
@chrysn chrysn deleted the more-periph branch November 30, 2024 10:28
"periph_uart_hw_fc",
"periph_uart_modecfg",
"periph_uart_nonblocking",
"periph_uart periph_uart_modecfg",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that was my lack of proper self-review :-(

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😏 you know, you can ask other to review... 😏

chrysn added a commit that referenced this pull request Dec 9, 2024
This was an overlooked editing mistake from [137].

[137]: #137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants