Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upkeep: update render-readme.yml #293

Closed
wants to merge 1 commit into from
Closed

upkeep: update render-readme.yml #293

wants to merge 1 commit into from

Conversation

jdhoffa
Copy link
Member

@jdhoffa jdhoffa commented Apr 11, 2024

Closes #258

@jdhoffa jdhoffa requested a review from MonikaFu as a code owner April 11, 2024 11:14
@MonikaFu
Copy link
Collaborator

Can you give me a bit more context on this please? It's not clear from the issue what this PR solves.

@jdhoffa
Copy link
Member Author

jdhoffa commented Apr 11, 2024

Hmmm this was meant to finally fix the render-readme.yml action but it seems that it still doesn't work, so I will close it again.

I am still trying to figure out what to do there honestly, I am tempted to just delete that action from every repo that uses it since it is never working as expected... what do you think?

@jdhoffa jdhoffa closed this Apr 11, 2024
@jdhoffa jdhoffa deleted the jdhoffa-patch-1 branch April 11, 2024 12:40
@MonikaFu
Copy link
Collaborator

Yeah, I remember it was what we did with Mauro back in the days as well. I'd be for just getting rid of it as it seems to be wasting a lot of our time and I'm not sure if the benefits of it are worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Render README CI fails to push change to PR branch
2 participants