Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scenario used #325

Merged
merged 4 commits into from
May 28, 2024
Merged

Update scenario used #325

merged 4 commits into from
May 28, 2024

Conversation

MonikaFu
Copy link
Collaborator

@MonikaFu MonikaFu commented May 24, 2024

Update the thresholds and default scenario to align with what will be used in Swiss COP 2024.

Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 9.69%. Comparing base (2d3f1ca) to head (7c67ff4).

Files Patch % Lines
R/prep_scores.R 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #325   +/-   ##
=====================================
  Coverage   9.69%   9.69%           
=====================================
  Files         27      27           
  Lines       2187    2187           
=====================================
  Hits         212     212           
  Misses      1975    1975           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexAxthelm
Copy link
Collaborator

@MonikaFu It looks like the extdata directory is big for this package. Is that expected?

https://github.com/RMI-PACTA/pacta.executive.summary/actions/runs/9226981271/job/25387941392?pr=325#step:6:291

@cjyetman
Copy link
Member

Looks like the documentation needs to be regenerated to avoid the Warning in R CMD check

@jdhoffa
Copy link
Member

jdhoffa commented May 27, 2024

I hope it's ok @MonikaFu I took the liberty to rebuild the docs since you are on PTO.
Checks should pass now

@jdhoffa
Copy link
Member

jdhoffa commented May 27, 2024

I see that the codecob/patch action is failing, though I remember we decided somewhere else that this was an action we might want to deactivate. @cjyetman can you remind me how/ where you disabled that portion of the codecov action?

See #326

@jdhoffa
Copy link
Member

jdhoffa commented May 27, 2024

@MonikaFu I think we will need to update this file as well, do you have any idea how to do this?
https://github.com/RMI-PACTA/pacta.executive.summary/blob/main/data-raw/remaining_carbon_budgets.R

Edit: Antoine is currently working on this. Tracked by #318

@cjyetman
Copy link
Member

I see that the codecob/patch action is failing, though I remember we decided somewhere else that this was an action we might want to deactivate. @cjyetman can you remind me how/ where you disabled that portion of the codecov action?

See #326

e.g. RMI-PACTA/pacta.portfolio.import#94

@MonikaFu
Copy link
Collaborator Author

@AlexAxthelm extdata contains all the Rmd templates and example images so yeah, to be expected I'd say. It is not ideal that the templates are part of this package probably. Going forward (if we are planning to generate executive summaries regularly) we should probably move them to a separate directory.

@MonikaFu
Copy link
Collaborator Author

Thanks @jdhoffa for taking care of the documentation! My bad. I will open a separate PR to remove the codecov action for now. In general since the PR is approved by @jdhoffa and @AlexAxthelm are we good to go to merge it now?

@jdhoffa
Copy link
Member

jdhoffa commented May 28, 2024

Good to merge!

@MonikaFu MonikaFu merged commit b61c49d into main May 28, 2024
9 checks passed
@MonikaFu MonikaFu deleted the update-scenario branch May 28, 2024 10:11
cjyetman pushed a commit to RMI-PACTA/workflow.transition.monitor that referenced this pull request Jun 10, 2024
Updating scenario source and scenario for executive summary
calculations. Aligned with what the team decided to use.

- [x] depends on
RMI-PACTA/pacta.executive.summary#325
- [x] depends on
RMI-PACTA/pacta.executive.summary#327

---------

Co-authored-by: Jackson Hoffart <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants