-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update scenario used #325
Update scenario used #325
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
=====================================
Coverage 9.69% 9.69%
=====================================
Files 27 27
Lines 2187 2187
=====================================
Hits 212 212
Misses 1975 1975 ☔ View full report in Codecov by Sentry. |
@MonikaFu It looks like the |
Looks like the documentation needs to be regenerated to avoid the |
I hope it's ok @MonikaFu I took the liberty to rebuild the docs since you are on PTO. |
@MonikaFu I think we will need to update this file as well, do you have any idea how to do this? Edit: Antoine is currently working on this. Tracked by #318 |
@AlexAxthelm extdata contains all the Rmd templates and example images so yeah, to be expected I'd say. It is not ideal that the templates are part of this package probably. Going forward (if we are planning to generate executive summaries regularly) we should probably move them to a separate directory. |
Thanks @jdhoffa for taking care of the documentation! My bad. I will open a separate PR to remove the |
Good to merge! |
Updating scenario source and scenario for executive summary calculations. Aligned with what the team decided to use. - [x] depends on RMI-PACTA/pacta.executive.summary#325 - [x] depends on RMI-PACTA/pacta.executive.summary#327 --------- Co-authored-by: Jackson Hoffart <[email protected]>
Update the thresholds and default scenario to align with what will be used in Swiss COP 2024.