Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/334 remove indices from score card dir #335

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Feat/334 remove indices from score card dir #335

merged 3 commits into from
Jun 18, 2024

Conversation

AlexAxthelm
Copy link
Collaborator

@AlexAxthelm AlexAxthelm commented Jun 18, 2024 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented Jun 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@93f8072). Learn more about missing BASE report.

Files Patch % Lines
R/prep_data_executive_summary.R 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff           @@
##             main    #335   +/-   ##
======================================
  Coverage        ?   9.69%           
======================================
  Files           ?      27           
  Lines           ?    2187           
  Branches        ?       0           
======================================
  Hits            ?     212           
  Misses          ?    1975           
  Partials        ?       0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexAxthelm AlexAxthelm mentioned this pull request Jun 18, 2024
Merged
@AlexAxthelm AlexAxthelm marked this pull request as ready for review June 18, 2024 13:40
@AlexAxthelm
Copy link
Collaborator Author

@jacobvjk @MonikaFu The ES seems to build clean with no "bonus" indices. See the renders: RMI-PACTA/workflow.transition.monitor#326 (comment)

MonikaFu
MonikaFu approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@MonikaFu MonikaFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume this will follow a PR in templates.transition.monitor where we change the directory pointing to the indices?

@AlexAxthelm
Copy link
Collaborator Author

LGTM. I assume this will follow a PR in templates.transition.monitor where we change the directory pointing to the indices?

Yep 326 in that repo.

@AlexAxthelm AlexAxthelm merged commit 91a070f into main Jun 18, 2024
9 checks passed
@AlexAxthelm AlexAxthelm deleted the feat/334-remove-indices-from-score-card-dir branch June 18, 2024 15:02
AlexAxthelm added a commit to RMI-PACTA/workflow.transition.monitor that referenced this pull request Jun 18, 2024
@AlexAxthelm
Restore main branch following merge of ES PR
d9ed863 
RMI-PACTA/pacta.executive.summary#335
AlexAxthelm added a commit to RMI-PACTA/workflow.transition.monitor that referenced this pull request Jun 18, 2024
@AlexAxthelm
Point to testing files with no indices (#326)
27caacd 
Closes #325 

Depends on RMI-PACTA/pacta.executive.summary#335
@AlexAxthelm AlexAxthelm mentioned this pull request Jun 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonikaFu MonikaFu MonikaFu approved these changes

@jacobvjk jacobvjk Awaiting requested review from jacobvjk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexAxthelm @MonikaFu