-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update scorecard to use new SBTi calculations #346
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
========================================
- Coverage 9.58% 9.57% -0.01%
========================================
Files 27 27
Lines 2212 2213 +1
========================================
Hits 212 212
- Misses 2000 2001 +1 ☔ View full report in Codecov by Sentry. |
This was referenced Jul 1, 2024
@AlexAxthelm @cjyetman tagging you here for visibility. |
cjyetman
reviewed
Jul 1, 2024
AlexAxthelm
approved these changes
Jul 2, 2024
This was referenced Jul 2, 2024
jdhoffa
pushed a commit
to RMI-PACTA/workflow.transition.monitor
that referenced
this pull request
Jul 2, 2024
With the new SBTi calculation we need to pass to executive summary the directory when pacta inputs are because that is where the file with SBTi data merged with FactSet data will live. This depends on a PR in executive summary: RMI-PACTA/pacta.executive.summary#346. This PR needs to be merged first for this one to work. Also, the `pacta-data` folder needs to contain `fin_data_net_zero_targets.csv` and has to use the most recent version of the testing `user_data` (https://github.com/RMI-PACTA/user_results/pull/24/files/f75b9955f640a74124003e524a6a5789d9b616b8..355ef24f21422238c88be9ad6ff571ef2d5e56db). --------- Co-authored-by: CJ Yetman <[email protected]> Co-authored-by: Alex Axthelm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on code implemented in #340, making it fully functional together with RMI-PACTA/workflow.transition.monitor#331.
NOTE: Also, for the PR to run without errors the
pacta-data
folder needs to containfin_data_net_zero_targets.csv
and has to use the most recent version of the testing user_data (https://github.com/RMI-PACTA/user_results/pull/24/files/f75b9955f640a74124003e524a6a5789d9b616b8..355ef24f21422238c88be9ad6ff571ef2d5e56db).