Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scorecard to use new SBTi calculations #346

Merged
merged 4 commits into from
Jul 2, 2024

Conversation

MonikaFu
Copy link
Collaborator

@MonikaFu MonikaFu commented Jun 28, 2024

This PR builds on code implemented in #340, making it fully functional together with RMI-PACTA/workflow.transition.monitor#331.

NOTE: Also, for the PR to run without errors the pacta-data folder needs to contain fin_data_net_zero_targets.csv and has to use the most recent version of the testing user_data (https://github.com/RMI-PACTA/user_results/pull/24/files/f75b9955f640a74124003e524a6a5789d9b616b8..355ef24f21422238c88be9ad6ff571ef2d5e56db).

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 9.57%. Comparing base (9269eae) to head (981ac61).

Files Patch % Lines
R/render_executive_summary.R 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #346      +/-   ##
========================================
- Coverage   9.58%   9.57%   -0.01%     
========================================
  Files         27      27              
  Lines       2212    2213       +1     
========================================
  Hits         212     212              
- Misses      2000    2001       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MonikaFu
Copy link
Collaborator Author

MonikaFu commented Jul 1, 2024

@AlexAxthelm @cjyetman tagging you here for visibility.

@MonikaFu MonikaFu marked this pull request as ready for review July 2, 2024 10:35
@MonikaFu MonikaFu merged commit 14575e1 into main Jul 2, 2024
9 checks passed
@MonikaFu MonikaFu deleted the update-sbti-section-scorecard branch July 2, 2024 10:46
jdhoffa pushed a commit to RMI-PACTA/workflow.transition.monitor that referenced this pull request Jul 2, 2024
With the new SBTi calculation we need to pass to executive summary the
directory when pacta inputs are because that is where the file with SBTi
data merged with FactSet data will live.

This depends on a PR in executive summary:
RMI-PACTA/pacta.executive.summary#346. This PR
needs to be merged first for this one to work. Also, the `pacta-data`
folder needs to contain `fin_data_net_zero_targets.csv` and has to use
the most recent version of the testing `user_data`
(https://github.com/RMI-PACTA/user_results/pull/24/files/f75b9955f640a74124003e524a6a5789d9b616b8..355ef24f21422238c88be9ad6ff571ef2d5e56db).

---------

Co-authored-by: CJ Yetman <[email protected]>
Co-authored-by: Alex Axthelm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants