Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: allow cement as an input sector to plot_scores #348

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Conversation

jdhoffa
Copy link
Member

@jdhoffa jdhoffa commented Jul 3, 2024

@MonikaFu unless there is a specific reason not to?

Relates to RMI-PACTA/workflow.transition.monitor#333

and in particular
RMI-PACTA/workflow.transition.monitor#333 (comment)

Copy link
Collaborator

@MonikaFu MonikaFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason not to include it. It was excluded because of the previous scenario we used.

@MonikaFu MonikaFu self-requested a review July 3, 2024 12:32
Copy link
Collaborator

@MonikaFu MonikaFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the test snapshots. Error messages have changed and that is why tests are failing.

@jdhoffa
Copy link
Member Author

jdhoffa commented Jul 3, 2024

Silly me thinking I could do this from the GH GUI haha XD

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.57%. Comparing base (14575e1) to head (6f6ed12).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #348   +/-   ##
=====================================
  Coverage   9.57%   9.57%           
=====================================
  Files         27      27           
  Lines       2213    2213           
=====================================
  Hits         212     212           
  Misses      2001    2001           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdhoffa jdhoffa requested a review from MonikaFu July 3, 2024 13:15
@jdhoffa jdhoffa merged commit a80f1c1 into main Jul 3, 2024
9 checks passed
@jdhoffa jdhoffa deleted the jdhoffa-patch-1 branch July 3, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants