Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for initial (dev) release #17

Merged
merged 12 commits into from
Feb 5, 2024
Merged

Conversation

AlexAxthelm
Copy link
Contributor

Housekeeping actions in preparation for an initial release (still an work in progress, but growing more stable)

@AlexAxthelm AlexAxthelm self-assigned this Jan 31, 2024
Copy link

github-actions bot commented Jan 31, 2024

Docker image from this PR (4df560b) created

docker pull ghcr.io/rmi-pacta/workflow.portfolio.parsing:pr17

Copy link

codecov bot commented Jan 31, 2024

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@AlexAxthelm AlexAxthelm marked this pull request as ready for review February 5, 2024 13:53
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly blocking these changes, but I think we need to better define our team practices for these changes to really mean something.

@AlexAxthelm could be a good indication that some of the practices pointed to should be prioritized in this Dev Hangout (also noting that my PR to document our maintainer definition hasn't been reviewed by anyone yet).

.github/workflows/R-test-coverage.yml Show resolved Hide resolved
.github/workflows/R-test-coverage.yml Show resolved Hide resolved
.github/workflows/R-test-coverage.yml Show resolved Hide resolved
DESCRIPTION Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@jdhoffa
Copy link
Member

jdhoffa commented Feb 5, 2024

Housekeeping actions in preparation for an initial release (still an work in progress, but growing more stable)

Ah I didn't read this. In the case that this is "towards" a release, I would suggest leaving the DESCRIPTION file at a x.y.z.9000 version number to indicate it is not yet "released"

Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AlexAxthelm AlexAxthelm merged commit fa345d1 into main Feb 5, 2024
7 checks passed
@AlexAxthelm AlexAxthelm deleted the chore/prepare-for-dev-release branch February 5, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants