-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for initial (dev) release #17
Conversation
Docker image from this PR (4df560b) created
|
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
Otherwise Rscript outputs the object to stdout, which can mess with the logs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not strictly blocking these changes, but I think we need to better define our team practices for these changes to really mean something.
@AlexAxthelm could be a good indication that some of the practices pointed to should be prioritized in this Dev Hangout (also noting that my PR to document our maintainer
definition hasn't been reviewed by anyone yet).
Ah I didn't read this. In the case that this is "towards" a release, I would suggest leaving the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Housekeeping actions in preparation for an initial release (still an work in progress, but growing more stable)