Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DON'T MERGE - Triggering CI for German LaTeX #373

Closed
wants to merge 24 commits into from
Closed

DON'T MERGE - Triggering CI for German LaTeX #373

wants to merge 24 commits into from

Conversation

jdhoffa
Copy link
Member

@jdhoffa jdhoffa commented Oct 25, 2024

@hodie here!
How it works:
By changing the "Remotes" link in the DESCRIPTION, we can specify a branch of the dependency package.
Here I have specified the hodie-patch-1 branch of pacta.executive.summary to trigger a CI build based on this PR branch:
RMI-PACTA/pacta.executive.summary#376

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 25, 2024 •
edited
Loading

Docker build status

commit_time git_sha project_code holdings_date language peer_group report summary image
2024-10-30T13:32:00Z 9a8f9c4, GENERAL 2022Q4 EN other Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2022q4_general:20241030T134004Z
2024-10-30T13:32:00Z 9a8f9c4, GENERAL 2023Q4 EN other Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_general:20241030T134006Z
2024-10-30T13:32:00Z 9a8f9c4, PA2024CH 2023Q4 DE bank Report Summary transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20241030T134004Z
2024-10-30T13:32:00Z 9a8f9c4, PA2024CH 2023Q4 DE other Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20241030T134004Z
2024-10-30T13:32:00Z 9a8f9c4, PA2024CH 2023Q4 EN assetmanager Report Summary transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20241030T134004Z
2024-10-30T13:32:00Z 9a8f9c4, PA2024CH 2023Q4 EN bank Report Summary transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20241030T134004Z
2024-10-30T13:32:00Z 9a8f9c4, PA2024CH 2023Q4 EN insurance Report Summary transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20241030T134004Z
2024-10-30T13:32:00Z 9a8f9c4, PA2024CH 2023Q4 EN other Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20241030T134004Z
2024-10-30T13:32:00Z 9a8f9c4, PA2024CH 2023Q4 EN pensionfund Report Summary transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20241030T134004Z
2024-10-30T13:32:00Z 9a8f9c4, PA2024CH 2023Q4 FR bank Report Summary transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20241030T134004Z
2024-10-30T13:32:00Z 9a8f9c4, PA2024CH 2023Q4 FR other Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20241030T134004Z
2024-10-30T13:32:00Z, 9a8f9c4, "ghcr.io/rmi-pacta/workflow.transition.monitor:pr-373"

@jdhoffa
Copy link
Member Author

jdhoffa commented Oct 29, 2024

@hodie note that you cannot specify a Remote for workflow.transition.monitor to install itself (it will always build from source).

I have added the changes you made in #374 to this PR, and we can test if it builds on CI. If it does, I will add those same changes in a separate PR to main.

@hodie
Copy link

hodie commented Oct 29, 2024

AH, okay, super helpful. Let me put the Babel package back in and rerun the tests, then.

hodie and others added 10 commits October 29, 2024 09:26
@hodie
Update Dockerfile
c2c5106 
Added polyglossia separately
@hodie
Update Dockerfile
f33bde0
@hodie
Update Dockerfile
584c821 
Removed babel dependency since we removed babel for now
@hodie
Update DESCRIPTION
9255a09
@hodie
Update rmi_pacta_2023q4_pa2024ch.json
812e347
@hodie
Update rmi_pacta_2023q4_pa2024ch.json
e89cb04
@hodie
Update rmi_pacta_2023q4_pa2024ch.json
a677a54 
I'm confused. The file here is still using user_id 74 and German reports but then on run, it uses the main version without German reports
@hodie
Merge branch 'main' into jdhoffa-patch-5
f772f0a
@hodie
Update rmi_pacta_2023q4_pa2024ch.json
88becc9 
Trying to use the earlier (before today) CH json file
@jdhoffa
Revert "Update rmi_pacta_2023q4_pa2024ch.json"
7507158 
This reverts commit 88becc9.
@jdhoffa jdhoffa marked this pull request as draft October 30, 2024 08:21
jdhoffa added a commit that referenced this pull request Oct 30, 2024
@jdhoffa
docker image gains LaTeX packages necessary for DE rendering
c02b483 
Tested here: #373
Required by: RMI-PACTA/pacta.executive.summary#376
@jdhoffa jdhoffa mentioned this pull request Oct 30, 2024
Merged
jdhoffa added a commit that referenced this pull request Oct 31, 2024
@jdhoffa
docker image gains LaTeX packages necessary for DE rendering (#378)
a71cda8 
Tested here:
#373
Required by:
RMI-PACTA/pacta.executive.summary#376
@jdhoffa jdhoffa closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAxthelm AlexAxthelm Awaiting requested review from AlexAxthelm AlexAxthelm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdhoffa @hodie @AlexAxthelm