Fixes for fastSyncRead() timeout and erronous packets that cause firmware to crash #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set correctly on subsequent fastRxStatusPacket calls
…m idle state. This fixes a case where if p_parse_packet->packet_len >= 4 and p_parse_packet->parse_state = DXL2_0_PACKET_PARSING_STATE_INST, these values are reset correctly.
jeevan-vexev
changed the title
- Ensure fast_param_state is always set to DXL_FAST_PARAM_ID - Ensure INST always is 0x55 prior to proceeding through the state machine as all DXL status packets respond with 0x55.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
info_rx_packet_.parse_statetoDXL2_0_PACKET_PARSING_STATE_IDLEafter a timeout to ensure it is reset correctly.xel_indexandbuf_indexare reset to zero. Right now, these are only reset to zero when a packet of a certain length is detected.