-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CHANGELOG.md #2035
base: develop
Are you sure you want to change the base?
Update CHANGELOG.md #2035
Conversation
@@ -1,74 +1,83 @@ | |||
# Change Log for Tensile | |||
# Changelog for Tensile | |||
|
|||
## (Unreleased) Tensile 4.42.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bstefanuk Can I replace this with Tensile 4.42.0 for ROCm 6.3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will do this during the FC process.
- Factor embed library logic into function and test | ||
- `clang++` as cxx-compiler option for Windows | ||
- Logic to cope with different compilers | ||
- `generateManifest` function and rename generateManifest to toFile and move to Utilities |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bstefanuk If we have renamed generateManifest function to toFile
already then why are we mentioning that we have added generateManifest function? Shouldn't we write "Added toFile function in Utilities".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This update is fine, but please mention that the generate manifest step has been moved into this function as well.
- Changed YAML operations to use C `libyaml` backend | ||
- Improved warning text | ||
- Updated clang support for Windows | ||
- Updated `supportedCompiler` function | ||
- use conditional choices and defaults |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bstefanuk What exactly is changing here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change this to "Use conditional choices and defaults for clang support on Windows"
- use glob to find logic files in TensileCreateLibrary | ||
- use function to confirm supported compiler rather than raw logic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bstefanuk What exactly is changing here? It seems like this should be listed under "Added".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A function was implemented to encapsulate logic.
Sometimes the difference between a change and addition is fuzzy, you can move this into "Added" if you please.
- Functions for writing master file | ||
- `tPrint` and reconcile printing options | ||
- Python unit test coverage report | ||
- Factor embed library logic into function and test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bstefanuk Factor embed logic or added embed logic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The items in the change log match the commit titles. Preferably, we want to keep it as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the term "factor" as it is technically more correct.
- Use analytical grid size prediction model for Stream-K | ||
- Remapped XCC-based workgroup for Stream-K kernels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bstefanuk I am not sure if these belong under "Optimized". The sentences don't clarify what is getting optimized. We can also add these under "Changed" and "Added".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no preference on this, any thoughts @babakpst or @AlexBrownAMD?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No real preference on where they belong, probably makes the most sense under either Optimized or Added. To clarify, these were new features added to optimize the performance of stream-k kernels.
Updated changelog as per doc standards