Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate rsyslog events #30

Open
wants to merge 1 commit into
base: rsyslog_forward
Choose a base branch
from
Open

Deduplicate rsyslog events #30

wants to merge 1 commit into from

Conversation

dougszumski
Copy link
Collaborator

This isn't recommended, but we can use it if we hit performance issues.

@dougszumski
Deduplicate rsyslog events
f3279ab 
This isn't recommended, but we can use it if we hit performance issues.
JohnGarbutt
JohnGarbutt approved these changes Mar 18, 2019
View reviewed changes
Copy link
Collaborator

@JohnGarbutt JohnGarbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good actually. Why did we say its not recommended now?

My previous object was the notifications, but actually I think we get told what count of logs were suppressed, so we are probably OK.

@dougszumski
Copy link
Collaborator Author

Yeah, I guess I'm a little scared that the count of suppressed logs might break a regex which would otherwise match, for example in mtail. Maybe alert-manager should do the suppression? I will investigate this a little more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnGarbutt JohnGarbutt JohnGarbutt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dougszumski @JohnGarbutt