Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the
activitysim/core/estimation.py
file, focusing on the configuration and validation of estimation settings using Pydantic models. The most important changes include the addition of new Pydantic classes for configuration, refactoring of theEstimator
class to use these new configurations, and the replacement of dictionary-based settings access with attribute-based access.Configuration and Validation Improvements:
SurveyTableConfig
,EstimationTableRecipeConfig
, andEstimationConfig
to handle configuration settings with validation. (activitysim/core/estimation.py
)model_estimation_table_types
againstestimation_table_recipes
. (activitysim/core/estimation.py
)Refactoring:
Estimator
class to use the new Pydantic models for configuration settings, replacing dictionary-based settings. (activitysim/core/estimation.py
) [1] [2]get
methods. (activitysim/core/estimation.py
) [1] [2] [3] [4] [5] [6] [7] [8]Initialization:
initialize_settings
method inEstimationManager
to read settings using the newEstimationConfig
Pydantic model. (activitysim/core/estimation.py
) [1] [2]These changes enhance the robustness and maintainability of the estimation configuration handling in the codebase. checking of estimation mode settings.