Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] add nrf5340 ci config #9570

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

hydevcode
Copy link
Contributor

@hydevcode hydevcode commented Oct 22, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

分别添加nrf5340中driver下面的所有文件的attach

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:bsp/nrf5x/nrf5340
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@github-actions github-actions bot added BSP action github action yml imporve labels Oct 22, 2024
@hydevcode hydevcode marked this pull request as draft October 22, 2024 14:33
@hydevcode hydevcode force-pushed the nrf5340 branch 2 times, most recently from 640affd to 6db9a4a Compare October 22, 2024 19:50
@hydevcode hydevcode marked this pull request as ready for review October 22, 2024 20:13
Comment on lines +2 to +3
CONFIG_BSP_USING_I2C0=n
CONFIG_BSP_USING_I2C1=n
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=n不用写呀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

发现i2c开了之后默认就会打开BSP_USING_I2C0然后跟串口的SERIAL0_IRQHandler冲突,导致编译报错,这里设置=n就可以关掉了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

图片
就像这样

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以的,这里有坑,非常好。感谢反馈

@supperthomas supperthomas marked this pull request as draft October 23, 2024 03:51
@supperthomas
Copy link
Member

请帮忙添加其他的attach,覆盖driver下面的所有文件。

@hydevcode
Copy link
Contributor Author

hydevcode commented Oct 23, 2024

请帮忙添加其他的attach,覆盖driver下面的所有文件。

已添加完所有attach,另外nrfx-latest软件包仓库那边也提交了一份修复兼容的pr,等待那边pr通过后,这边的ci才能过

@hydevcode hydevcode marked this pull request as ready for review October 23, 2024 18:05
Copy link
Member

@supperthomas supperthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

非常好的pr

@mysterywolf mysterywolf merged commit 40124ca into RT-Thread:master Oct 23, 2024
45 checks passed
@hydevcode hydevcode deleted the nrf5340 branch October 23, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action github action yml imporve BSP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants