[components][finsh]在RT_USING_POSIX_STDIO时，使用get_console获取当前console描述符 #9581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mysterywolf
requested changes
Oct 25, 2024
components/finsh/shell.c
Outdated
| @@ -149,12 +149,25 @@ void finsh_set_prompt_mode(rt_uint32_t prompt_mode) | |||
| shell->prompt_mode = prompt_mode; | |||
| } | |||
|
|
|||
| #ifdef RT_USING_POSIX_STDIO | |||
| #if RT_VER_NUM >= 0x50100 | |||
There was a problem hiding this comment.
嗯 搜了下确实master里边没有这种宏
如果有个bug，master v5.1.x等多个分支都需要修复，应该怎么操作呢？每个分支都提交修复commit？
There was a problem hiding this comment.
但是这里的libc.h以及get_console接口在 b08d867 这个commit被重构了，作者是你，如果不加版本宏区分是不能直接cherrypick的
mysterywolf
reviewed
Oct 30, 2024
| int finsh_getchar(void) | ||
| { | ||
| #ifdef RT_USING_DEVICE | ||
| char ch = 0; | ||
| #ifdef RT_USING_POSIX_STDIO | ||
| if(read(STDIN_FILENO, &ch, 1) > 0) | ||
| #if RT_VER_NUM >= 0x50100 | ||
| if(read(rt_posix_stdio_get_console(), &ch, 1) > 0) |
There was a problem hiding this comment.
这块有问题呀，为什么直接使用STDIN_FILENO标准文件描述符不可以呢？
There was a problem hiding this comment.
实测打开telnet时，调用set_console的api后，STDIN_FILENO不起作用，无法获取输入，telnet我也有修改 RT-Thread-packages/netutils#105
There was a problem hiding this comment.
请麻烦单独提一个PR 至保留针对当前版本的代码 无需考虑之前版本的兼容，后续我会根据这个PR重新cherry-pick到其他分支
mysterywolf
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
[
为什么提交这份PR (why to submit this PR)
使用telnet，并打开RT_USING_POSIX_STDIO时，需使用get_console来get_char，否则不能正确获取输入
你的解决方案是什么 (what is your solution)
get_char时使用get_console获取console描述符
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up