Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] add the yml file support #9610

Merged
merged 2 commits into from
Nov 5, 2024
Merged

[action] add the yml file support #9610

merged 2 commits into from
Nov 5, 2024

Conversation

supperthomas
Copy link
Member

@supperthomas supperthomas commented Nov 3, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

添加bsp的yml文件,功能和attach文件相似,yml文件比较容易修改和管理。当前attach文件和yml都可以用,目前叠加使用。

你的解决方案是什么 (what is your solution)

添加ci.yml文件

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added BSP action github action yml imporve tools labels Nov 3, 2024
@supperthomas supperthomas force-pushed the add_bsp_yml branch 5 times, most recently from 1e586c8 to ea7ee04 Compare November 3, 2024 09:47
@supperthomas
Copy link
Member Author

+1

@mysterywolf
Copy link
Member

mysterywolf commented Nov 3, 2024

麻烦把yml文件放到.ci文件夹下,ci.yml重命名为 xxx.attachconfig.yml,只要扫描到.attachconfig.yml即走yml逻辑,并确保采用.attachconfig的文件不收影响

@supperthomas supperthomas force-pushed the add_bsp_yml branch 3 times, most recently from bae8bbc to 3f4cc6c Compare November 4, 2024 03:29
@supperthomas
Copy link
Member Author

麻烦把yml文件放到.ci文件夹下,ci.yml重命名为 xxx.attachconfig.yml,只要扫描到.attachconfig.yml即走yml逻辑,并确保采用.attachconfig的文件不收影响

已加

@mysterywolf mysterywolf merged commit 96165a5 into master Nov 5, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action github action yml imporve BSP tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants