-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JOSS paper on v3 #1461
base: main
Are you sure you want to change the base?
JOSS paper on v3 #1461
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1461 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 61 61
Lines 21337 21337
=======================================
Hits 21322 21322
Misses 15 15 ☔ View full report in Codecov by Sentry. |
13563a0
to
345cbb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking very good, just a few comments
Alright, moving this out of draft status and into "ready" status, just to mark my intention to start wrapping this up. @bhazelton @mkolopanis @steven-murray @adampbeardsley @dannyjacobs @nkern @aelanman @plaplant @jpober @PyxieLouStar -- can you check your author information (name, affiliation, and ORCID ID) and confirm that you are interested in being listed as a co-author? (I'm assuming as much for the current regulars on the weekly call, but want to try to touch base w/ everyone before submission). I'm hoping to get this out the door by Aug 20, so a response sooner rather than later would be appreciated! |
Looks good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment on my affiliation, otherwise all good. Thanks @kartographer!
Noting that on the telecon we discussed adding a "what's new" section to the paper, so I'm going to work on adding that... |
Looks good to me too. Thanks for pushing this through Karto. |
Looks good to me, thanks @kartographer! |
15e5284
to
814ac11
Compare
Looks good to me! |
f0dccaf
to
bc05d63
Compare
@nkern @PyxieLouStar: I'm going to try and get this sent out, so I wanted to send one more ping -- can you confirm if you'd like to be on the paper (otherwise I'll assuming I should take you off). Thanks! |
Hi @kartographer--sorry for the late response, i don't have github notifications on.. anyways, yes I'd be happy to be on the author list. Both my orcid and my affil are correct! lmk if anything else comes up. :) |
@kartographer my affiliation should be 3 rather than 2. Thank you! |
beb62a1
to
1985db4
Compare
1985db4
to
b6b2f3b
Compare
Description
As mentioned on a few telecons, now that we finally got v3 out the door, I'd like to get a brief updated JOSS paper out about the new version.
I pulled the author list from the updated maintainers an authors list, putting maintainers + authors first and then authors only second. Obviously this is a first pass (and as such, institutions, names, OCRID IDs will need to get confirmed).
Comments welcome! I kept the update relatively short -- I thought about adding a section on major changes since v2, but decided against it for the moment (though I'd happy to discuss that or any other additions).
Motivation and Context
Types of changes
Checklist:
Documentation change checklist: