Faster-unprojected-new #1488
Open
Faster-unprojected-new #1488
+124
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhazelton
reviewed
Oct 21, 2024
steven-murray
force-pushed
the
lower-memory-beam-interp
branch
from
50b3c89
to
c144d92
Compare
steven-murray
force-pushed
the
faster-unprojected-new
branch
2 times, most recently
from
76974d9
to
fdd963c
Compare
steven-murray
force-pushed
the
lower-memory-beam-interp
branch
from
0e530e3
to
c64fa02
Compare
steven-murray
force-pushed
the
faster-unprojected-new
branch
from
d05321a
to
8c6ce35
Compare
bhazelton
reviewed
Nov 5, 2024
| checking of the created object. | ||
| - New keyword `all_times_unique` to `calc_app_coords` that short-cuts the calculation | ||
| when it is known that all input times are unique. | ||
|
|
There was a problem hiding this comment.
This needs to be rebased and then this section needs to be combined with the Added section that's already in main, it's above the changed section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes both the setting of the UVWs and the setting of the app coords faster when you're initializing an empty UVData for which the baseline-times are rectangular.
Motivated by running HERA simulations: for redundant groups of the full HERA-350 and 17280 times, these operations were taking ~40min. I haven't timed them yet with the updated code, but tests on smaller sizes show at least 2 orders of magnitude speed up.
Motivation and Context
Types of changes
Checklist:
Performance enhancement: