Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String tools #745

Merged
merged 6 commits into from
Nov 26, 2023
Merged

String tools #745

merged 6 commits into from
Nov 26, 2023

Conversation

RainerKuemmerle
Copy link
Owner

No description provided.

The example was not compiled since some time and it contained errors.
Removed
* formatString
* strPrintf
* G2O_ATTRIBUTE_FORMAT12
* G2O_ATTRIBUTE_FORMAT23
Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (0c278d8) 50.96% compared to head (dfaa267) 50.87%.

Files Patch % Lines
g2o/solvers/structure_only/structure_only_solver.h 0.00% 3 Missing ⚠️
g2o/core/sparse_block_matrix.hpp 0.00% 2 Missing ⚠️
g2o/core/sparse_optimizer.cpp 66.66% 2 Missing ⚠️
g2o/stuff/command_args.cpp 0.00% 2 Missing ⚠️
g2o/core/base_vertex.hpp 0.00% 1 Missing ⚠️
g2o/types/sba/edge_project_p2mc.cpp 0.00% 1 Missing ⚠️
g2o/types/sba/edge_project_p2sc.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #745      +/-   ##
==========================================
- Coverage   50.96%   50.87%   -0.10%     
==========================================
  Files         271      271              
  Lines       10989    10969      -20     
==========================================
- Hits         5601     5580      -21     
- Misses       5388     5389       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Use std functions
@RainerKuemmerle RainerKuemmerle merged commit 8aec921 into master Nov 26, 2023
6 of 7 checks passed
@RainerKuemmerle RainerKuemmerle deleted the string_tools branch November 26, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant