Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #185; allow multiple users in the same python script #186

Closed
wants to merge 1 commit into from

Conversation

Celthi
Copy link

@Celthi Celthi commented Feb 10, 2022

fix #185

Copy link

@jofegan jofegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making a copy of the dict makes sense to me, but I would use dict.copy() explicitly so that the intent is clear to future readers.

pyral/restapi.py Outdated Show resolved Hide resolved
@Celthi
Copy link
Author

Celthi commented Feb 11, 2022

Making a copy of the dict makes sense to me, but I would use dict.copy() explicitly so that the intent is clear to future readers.

Good catch! Changed.

@jofegan
Copy link

jofegan commented Feb 11, 2022

I think this actually addresses a wider use case: does pyral support more than one Rally object in a single process? If so then this change is needed, because init takes a "headers" keyword but with the current code it is not possible to change the headers for one Rally object without affecting them all, because they are all pointing to the same static dict.

Copy link

@jofegan jofegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Celthi
Copy link
Author

Celthi commented Apr 19, 2022

Any plan to merge this fix?

@klehman-rally
Copy link
Member

This mod is included in the 1.6.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Will pyral support using multiple users?
3 participants