Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: 보유 쀑인 주식 ν…ŒμŠ€νŠΈ μ½”λ“œ μž‘μ„± #233

Merged
merged 1 commit into from
Oct 13, 2024
Merged

πŸ”€ :: 보유 쀑인 주식 ν…ŒμŠ€νŠΈ μ½”λ“œ μž‘μ„± #233

merged 1 commit into from
Oct 13, 2024

Conversation

Umjiseung
Copy link
Collaborator

πŸ’‘ λ°°κ²½ 및 κ°œμš”

보유 쀑인 주식관련 ν…ŒμŠ€νŠΈ μ½”λ“œ μž‘μ„±ν•˜μ˜€μŠ΅λ‹ˆλ‹€

Resolves: #232

πŸ“ƒ μž‘μ—…λ‚΄μš©

  • GetMyOwnedStockServiceImplTest μΆ”κ°€

βœ… PR 체크리슀트

ν…œν”Œλ¦Ώ 체크리슀트 말고도 μΆ”κ°€μ μœΌλ‘œ ν•„μš”ν•œ μ²΄ν¬λ¦¬μŠ€νŠΈλŠ” μΆ”κ°€ν•΄μ£Όμ„Έμš”!

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. .env, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "ν™˜κ²½κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@Umjiseung Umjiseung added ✨ Feature κΈ°λŠ₯ 개발 βœ… Test test κ΄€λ ¨(xctest, rxtest, nimble ...color) labels Oct 13, 2024
@Umjiseung Umjiseung self-assigned this Oct 13, 2024
@Umjiseung Umjiseung linked an issue Oct 13, 2024 that may be closed by this pull request
λ‚΄κ°€ 가지고 μžˆλŠ” 주식 리슀트 ν…ŒμŠ€νŠΈ μ½”λ“œ #232
Closed
@Umjiseung Umjiseung merged commit 13252fd into develop Oct 13, 2024
1 check passed
@Umjiseung Umjiseung deleted the feature/232-my-have-ing-stock-list-test-code branch October 13, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Umjiseung Umjiseung

Labels
✨ Feature κΈ°λŠ₯ 개발 βœ… Test test κ΄€λ ¨(xctest, rxtest, nimble ...color)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

λ‚΄κ°€ 가지고 μžˆλŠ” 주식 리슀트 ν…ŒμŠ€νŠΈ μ½”λ“œ
1 participant
@Umjiseung