Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: ๋กœ๊ทธ์ธ api ๊ตฌํ˜„ #34

Merged
merged 8 commits into from
Jun 18, 2024

Conversation

Umjiseung
Copy link
Collaborator

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

๋กœ๊ทธ์ธ api๋ฅผ ๊ตฌํ˜„ํ•˜์˜€์Šต๋‹ˆ๋‹ค

Resolves: #33

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

๏ฟฝ๋กœ๊ทธ์ธ api๋ฅผ ์ถ”๊ฐ€ํ•˜์˜€๊ณ  ์ด๋ฉ”์ผ ์ธ์ฆ์ด ๋˜์–ด์žˆ์ง€ ์•Š์œผ๋ฉด ์˜ˆ์™ธ์ฒ˜๋ฆฌ ํ•ธ๋“ค๋ง์„ ํ•˜์˜€์Šต๋‹ˆ๋‹ค

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. .env, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "ํ™˜๊ฒฝ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@Umjiseung Umjiseung added 1๏ธโƒฃPriority: High ์šฐ์„ ์ˆœ์œ„ ์ƒ ๐Ÿ“ฌ API ์„œ๋ฒ„ API ํ†ต์‹  โœจ Feature ๊ธฐ๋Šฅ ๊ฐœ๋ฐœ labels Jun 18, 2024
@Umjiseung Umjiseung self-assigned this Jun 18, 2024
@Umjiseung Umjiseung linked an issue Jun 18, 2024 that may be closed by this pull request
@Umjiseung Umjiseung merged commit d2156b0 into develop Jun 18, 2024
1 check passed
@Umjiseung Umjiseung deleted the feature/33-signin-api-add branch June 18, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1๏ธโƒฃPriority: High ์šฐ์„ ์ˆœ์œ„ ์ƒ ๐Ÿ“ฌ API ์„œ๋ฒ„ API ํ†ต์‹  โœจ Feature ๊ธฐ๋Šฅ ๊ฐœ๋ฐœ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

signin api ๊ฐœ๋ฐœ
1 participant