Merging develop into development-guidelines #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TheoPannetier Am I missing some other changes? I thought that merging the changes of cmake_batch (now merged to develop) into development_guidelines should be fine? Why is it now complaining about the checks? |
|
@JetteReeg the RSrandom file was missing some includes for testing functions. I'm not sure why this hasn't been an issue earlier, but |
TheoPannetier
added a commit
that referenced
this pull request
Feb 6, 2024
Merge pull request #21 from RangeShifter/develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before merging development-guidelines into develop, I wanted to merge the new changes of the develop branch into development_guidelines which includes: