author : justniub #212
Open
author : justniub #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
date : 20210412 modify : solve the save bug in demo/demo.py
RangiLyu
requested changes
Apr 12, 2021
| save_folder = args.save_path if args.save_path else os.path.join(cfg.save_dir, | ||
| time.strftime("%Y_%m_%d_%H_%M_%S", | ||
| current_time)) | ||
| if not os.path.exists(save_folder): |
There was a problem hiding this comment.
Use mkdir function in nanodet.util
logs.txt
Outdated
| @@ -0,0 +1 @@ | |||
| INFO:root:Press "Esc", "q" or "Q" to exit. | |||
demo/demo.py
Outdated
| args = parser.parse_args() | ||
|
|
||
| # print(args) |
demo/demo.py
Outdated
| @@ -8,7 +8,7 @@ | |||
| from nanodet.util import load_model_weight | |||
| from nanodet.data.transform import Pipeline | |||
|
|
|||
| image_ext = ['.jpg', '.jpeg', '.webp', '.bmp', '.png'] | |||
| image_ext = ['.jpg', '.jpeg', '.webp', '.bmp', '.png','.JPG'] | |||
There was a problem hiding this comment.
I don't think .JPG is a necessary file extension. But if you think this is useful, other file extensions should also have a uppercase version.
There was a problem hiding this comment.
You can do something like this:
image_ext = ['.jpg', '.jpeg', '.webp', '.bmp', '.png']
image_ext += [x.upper() for x in image_ext]| for image_name in files: | ||
| meta, res = predictor.inference(image_name) | ||
| result_image = predictor.visualize(res, meta, cfg.class_names, 0.35) | ||
|
|
There was a problem hiding this comment.
Too many unnecessary line breaks.
demo/demo.py
Outdated
| current_time)) | ||
| if not os.path.exists(save_folder): | ||
| os.makedirs(save_folder) | ||
| print(fr"make the save folder: {save_folder}") |
There was a problem hiding this comment.
replace print with logging.info
demo/demo.py
Outdated
| save_path = os.path.join(save_folder, args.path.split('/')[-1]) if args.demo == 'video' else os.path.join(save_folder, 'camera.mp4') | ||
| print(f'save_path is {save_path}') | ||
| vid_writer = cv2.VideoWriter(save_path, cv2.VideoWriter_fourcc(*'mp4v'), fps, (int(width), int(height))) | ||
| print(args.save_path) |
There was a problem hiding this comment.
replace print with logging.info
demo/demo.py
Outdated
| save_folder, 'camera.mp4') | ||
|
|
||
| vid_writer = cv2.VideoWriter(save_path, -1, fps, (int(width), int(height))) | ||
| print(fr"make the save folder: {save_folder}") |
There was a problem hiding this comment.
replace print with logging.info
demo/demo.py
Outdated
| while True: | ||
| ret_val, frame = cap.read() | ||
| if ret_val: | ||
| meta, res = predictor.inference(frame) | ||
| result_frame = predictor.visualize(res, meta, cfg.class_names, 0.35) | ||
|
|
There was a problem hiding this comment.
Too many unnecessary line breaks.
demo/demo.py
Outdated
| if args.save_result: | ||
| vid_writer.write(result_frame) | ||
|
|
There was a problem hiding this comment.
Too many unnecessary line breaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
date : 20210412
modify : solve the save bug in demo/demo.py