Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the sella env #748

Merged
merged 2 commits into from
Jun 23, 2024
Merged

Fixed the sella env #748

merged 2 commits into from
Jun 23, 2024

Conversation

kfir4444
Copy link
Collaborator

Numpy came up with version 2.0.0, which modified the API. Sella still works with <2.0.0, so locked in the last version.

Version lock numpy to the last <2 version, until other packages catch up.
Copy link

codecov bot commented Jun 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.81%. Comparing base (3631196) to head (f399746).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #748   +/-   ##
=======================================
  Coverage   73.80%   73.81%           
=======================================
  Files          99       99           
  Lines       27352    27352           
  Branches     5718     5718           
=======================================
+ Hits        20187    20189    +2     
+ Misses       5738     5737    -1     
+ Partials     1427     1426    -1     
Flag Coverage Δ
unittests 73.81% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alongd alongd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alongd alongd merged commit eb91650 into main Jun 23, 2024
7 checks passed
@alongd alongd deleted the fix_xtb branch June 23, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants