Added assign_frequency_scale_factor() to Level #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongd
force-pushed
the
freq_factors
branch
4 times, most recently
from
453dc04
to
8d57f9d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #750 +/- ##
==========================================
+ Coverage 73.71% 73.74% +0.02%
==========================================
Files 99 99
Lines 27454 27472 +18
Branches 5783 5781 -2
==========================================
+ Hits 20238 20259 +21
Misses 5765 5765
+ Partials 1451 1448 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alongd
force-pushed
the
freq_factors
branch
5 times, most recently
from
4424bf7
to
15a8773
Compare
kfir4444
reviewed
Jul 10, 2024
arc/main.py
Outdated
| @@ -37,7 +36,7 @@ | |||
| ) | |||
| from arc.exceptions import InputError, SettingsError, SpeciesError | |||
| from arc.imports import settings | |||
| from arc.level import Level | |||
| from arc.level import Level,assign_frequency_scale_factor | |||
There was a problem hiding this comment.
@kfir4444, thanks - fixed
replacing a call to Arkane
Instead of Arkane's function
instead, just return the freq variant with the software info (Arkane should be able to deal with it and remove the software info if not needed)
before splitting them as str in ARC.as_dict() to avoid an IndexError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the data as a YAML file, the respective functionality, and tests