Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce clutter in restart dict #751

Merged
merged 8 commits into from
Jul 2, 2024
Merged

Reduce clutter in restart dict #751

merged 8 commits into from
Jul 2, 2024

Conversation

alongd
Copy link
Member

@alongd alongd commented Jun 28, 2024

Don't save default values of ARC, ARCSpecies, and ARCReaction objects as dictionaries
Tests modified accordingly

@alongd alongd changed the title Input defaultsReduce clutter in restart dict Reduce clutter in restart dict Jun 28, 2024
@alongd alongd requested a review from JintaoWu98 June 28, 2024 21:33
Copy link

codecov bot commented Jun 29, 2024

Codecov Report

Attention: Patch coverage is 54.45545% with 46 lines in your changes missing coverage. Please review.

Project coverage is 73.67%. Comparing base (34ef50d) to head (728aeea).

Files Patch % Lines
arc/main.py 25.71% 11 Missing and 15 partials ⚠️
arc/species/species.py 67.27% 8 Missing and 10 partials ⚠️
arc/reaction.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #751      +/-   ##
==========================================
- Coverage   73.77%   73.67%   -0.11%     
==========================================
  Files          99       99              
  Lines       27364    27406      +42     
  Branches     5723     5765      +42     
==========================================
+ Hits        20189    20190       +1     
- Misses       5748     5768      +20     
- Partials     1427     1448      +21     
Flag Coverage Δ
unittests 73.67% <54.45%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JintaoWu98 JintaoWu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alongd alongd merged commit 047f656 into main Jul 2, 2024
5 of 7 checks passed
@alongd alongd deleted the input_defaults branch July 2, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants