fixed coll freq unittest error and added in a note in the dev documentation regarding CamelCase syntax #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
input files had old LennardJones tranport attribute which now crashes cantherm. also fixed typo in cantherm/input.py
in cantherm input.py
the previous test was using the wrong numeric value for the collison frequency at the specified conditions. The test will pass now.
|
Thanks. I have rebased these onto master, to avoid the merge caused by whatever happened 14 days ago. @enochd, once you have got this, try doing a hard reset of your master onto the official one, to get back on track. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i think i have performed the proper git commands for this pull request. just a little confused why older commit/comments are showing up on my github website.
The collision frequency unittest was previously failing. I determined that it had an incorrect numeric value for whatever reason, and updated it. I also added a small note to the documentation.