Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upsert with retry implemented #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Upsert with retry implemented #18

wants to merge 2 commits into from

Conversation

HimanshuArora1234
Copy link

@HimanshuArora1234 HimanshuArora1234 commented Aug 10, 2017 •
edited
Loading

upsertWithRetry functuon added with retries on error using the real rx.Observable.retryWhen of RxJava

@mathieuancelin
Copy link
Member

That's nice but I'd like to use idiomatic Scala as much as possible and avoid rx apis. Can you rewrite it without depending on RetryWhenFunction in the public API ?

@HimanshuArora1234
Copy link
Author

Ok sure. Will do that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HimanshuArora1234 @mathieuancelin