Fix writes out of order #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continue to enqueue writes until queue is drained, to avoid that writes comes out of order when writes are triggered from both the event loop and other threads. Solves issue ReactiveX#605
|
Any maintainers available for review? @jamesgorman2 ? |
jamesgorman2
approved these changes
May 6, 2018
There was a problem hiding this comment.
LGTM
There might still be a race around the first off event loop write (a write(inEL) concurrent with the first write(!inEL)), but that already exists and isn't introduced by this PR.
@TurboProgramming I'm approving for now, but can you can have think and I'll merge or hold off after I do the same and get feedback from you
|
@jamesgorman2 any chance we can get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue to enqueue writes until queue is drained, to avoid that writes comes out of order when writes are triggered from both the event loop and other threads.
Solves issue #605