PoC: Noncopyable DisposeBag #2634
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikolaykasyanov
force-pushed
the
noncopyable-dispose-bag
branch
from
0ef09a5 to
5aebb54
Compare
nikolaykasyanov
commented
Oct 11, 2024
| @@ -26,14 +26,14 @@ extension DisposeBagTest { | |||
| let disposable1 = TestDisposable() | |||
| let disposable2 = TestDisposable() | |||
|
|
|||
| var disposeBag: DisposeBag? = DisposeBag() | |||
| var disposeBag: DisposeBag = DisposeBag() | |||
There was a problem hiding this comment.
In Xcode 15, noncopyable types can't be used as generic arguments, so no optional for us. If Xcode 15 compatibility isn't a concern, this and similar changes can be rolled back.
nikolaykasyanov
force-pushed
the
noncopyable-dispose-bag
branch
from
5aebb54 to
0cb9245
Compare
nikolaykasyanov
force-pushed
the
noncopyable-dispose-bag
branch
from
0cb9245 to
2c8982a
Compare
|
Closing as per discussion in #2633. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proof of concept for #2633.