Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(custom report): Use radio buttons for sort selection in dropdown #2146

Closed
wants to merge 1 commit into from

Conversation

leSamo
Copy link
Member

@leSamo leSamo commented Sep 29, 2024

https://issues.redhat.com/browse/RHINENG-12947

I was able to repurpose the existing RadioCustomFilter component which is already used for filters inside the same modal allowing me to remove the redundant SelectCustomSorter component.

Before

Screenshot from 2024-09-29 19-59-06

After

Screenshot from 2024-09-29 19-58-51

To test

  1. Navigate to Reports page
  2. Open custom report modal with Create report button
  3. Try to export PDF with the default selected sort
  4. Export PDF and check if CVEs are sorted properly (CVSS high to low)
  5. Open modal again and change the sorting
  6. Export PDF and check if CVEs are sorted properly

@leSamo leSamo requested a review from a team as a code owner September 29, 2024 17:56
Copy link

jira-linking bot commented Sep 29, 2024

Commits missing Jira IDs:
bce14d7

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.13%. Comparing base (0c9ebdf) to head (bce14d7).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2146      +/-   ##
==========================================
- Coverage   67.15%   67.13%   -0.02%     
==========================================
  Files         128      127       -1     
  Lines        3440     3426      -14     
  Branches     1067     1069       +2     
==========================================
- Hits         2310     2300      -10     
+ Misses       1130     1126       -4     
Flag Coverage Δ
67.13% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnsonm325
Copy link
Contributor

@leSamo see updated comment in the Jira card. I apologize for the lack of clarity.

@leSamo leSamo closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants