Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redot rebranding (Deref Godot: doc/) + fixed email / repo points #684

Closed
wants to merge 5 commits into from

Conversation

mcdubhghlas
Copy link
Contributor

Removal of a lot of Godot references. There are still some, but they exist for a reason (email +copyright, would break code, etc.)

I had to fix an email, plus changed several references to a fraudulent repo.

@Spartan322 Spartan322 added the bug label Oct 12, 2024
Copy link
Contributor

@Spartan322 Spartan322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be squaushed and the PR and commit should say something like Fix docs referencing Godot to Redot or something.

fixed pointing to incorrect repo.

fixed email.
@RadenTheFolf RadenTheFolf added the rebranding issues and pr's related to engine rebranding label Oct 12, 2024
@decryptedchaos
Copy link
Member

decryptedchaos commented Oct 12, 2024

  • doc/translations/de.po

still needs Deref in the repo URL still has the repo name as godot

@mcdubhghlas
Copy link
Contributor Author

Good catch!

Copy link
Member

@decryptedchaos decryptedchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, Except want to get some clarification from the rest of the team on these

I thought we decided to revert this to Godot Shader Language on the same premise that we are keeping GDScript as it reduces confusion on compatibility.

  • doc/classes/VisualShaderNodeIntFunc.xml
  • doc/classes/VisualShaderNodeIntOp.xml
  • doc/classes/VisualShaderNodeUIntFunc.xml
  • doc/classes/VisualShaderNodeUIntOp.xml

@mcdubhghlas
Copy link
Contributor Author

I have been busy IRL for the last three days so I hadn't gotten the memo if that was the case. I'll roll the back if need be.

@SkogiB
Copy link
Contributor

SkogiB commented Oct 15, 2024

Everything looks good, Except want to get some clarification from the rest of the team on these

I thought we decided to revert this to Godot Shader Language on the same premise that we are keeping GDScript as it reduces confusion on compatibility.

  • doc/classes/VisualShaderNodeIntFunc.xml
  • doc/classes/VisualShaderNodeIntOp.xml
  • doc/classes/VisualShaderNodeUIntFunc.xml
  • doc/classes/VisualShaderNodeUIntOp.xml

Correct, we need to revert any instances of "RDShader", "Redot Shader Language" etc

@mcdubhghlas
Copy link
Contributor Author

I'll get this sorted later and try to squash everything together. If worst comes to worst, I'll just redo this unless someone wants to let me know what I need to run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug rebranding issues and pr's related to engine rebranding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants