Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(API_GetUserSummary): handle username case sensitivity and use canonical username #2854

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
+2 −2
Open

fix(API_GetUserSummary): handle username case sensitivity and use canonical username #2854

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3d1ec1c
fix(API_GetUserSummary): use canonical username for UserPic path
G3mha Nov 16, 2024
c252da0
fix(API_GetUserSummary): handle username case sensitivity in query an…
G3mha Nov 16, 2024
e289d64
fix(API_GetUserSummary): reorder import statements for Composer Fix
G3mha Nov 16, 2024
a740255
Merge branch 'RetroAchievements:master' into master
G3mha Nov 16, 2024
63b9418
fix(User): Restore the method `scopeByDisplayName` to its previous state
G3mha Nov 17, 2024
23d4031
fix(API_GetUserSummary): simplify username handling and improve case …
G3mha Nov 17, 2024
b870071
fix(API_GetUserSummary): disable test `testUsernameCaseConsistency` t…
G3mha Nov 17, 2024
eecfc10
fix(API_GetUserSummary): remove test `testUsernameCaseConsistency` du…
G3mha Nov 17, 2024
ec790a8
Merge branch 'master' into fix/case-insensitive-username-lookup
G3mha Nov 17, 2024
bb43d6e
Merge branch 'RetroAchievements:master' into master
G3mha Nov 17, 2024
d43d211
Merge branch 'master' into fix/case-insensitive-username-lookup
G3mha Nov 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions public/API/API_GetUserSummary.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@
], 404);
}

$retVal['UserPic'] = "/UserPic/" . $user . ".png";
$retVal['UserPic'] = "/UserPic/" . $retVal['User'] . ".png";
$retVal['TotalRanked'] = countRankedUsers();

// assume caller doesn't care about the rich presence script for the last game played
Expand All @@ -131,7 +131,7 @@
'timestamp' => null,
'lastupdate' => null,
'activitytype' => null,
'User' => $user,
'User' => $retVal['User'],
'data' => null,
'data2' => null,
];
Expand Down