Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation and sample code regarding SQLite data provider #177

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

0xced
Copy link

@0xced 0xced commented Sep 16, 2019

Westwind.Utilities dropped support for Microsoft.Data.Sqlite in RickStrahl/Westwind.Utilities@f2bf12a

This change is reflected here in Westwind.Globalization, documentation, tests and sample code.

@0xced
Copy link
Author

0xced commented Nov 18, 2019

Ping.

@RickStrahl
Copy link
Owner

This was removed because of dependencies - we don't want to ship all the DB provider dependencies. How to deal with the other providers was left on the the todo list, but just adding the dependency to the project isn't going to happen unfortunately.

In full framework this was reasonably easy to deal with by not explicitly pulling in a package.

I think what's needed is to have separate packages for each provider supported to pull in the database packages. They don't even have to do anything other than have the package references and the specific provider support. I have to take a look at that - I don't even remember how the providers get loaded in the first place :-)

@0xced 0xced changed the title Fix SQLite data provider Fix documentation and sample code regarding SQLite data provider Mar 2, 2020
@0xced
Copy link
Author

0xced commented Mar 2, 2020

but just adding the dependency to the project isn't going to happen unfortunately

This pull request is not about adding the dependency to the Westwind.Globalization project, but about fixing the documentation and sample code to match the current state (after commit RickStrahl/Westwind.Utilities@f2bf12a). I updated the pull request title accordingly.

Westwind.Utilities dropped support for Microsoft.Data.Sqlite in RickStrahl/Westwind.Utilities@f2bf12a

This change is reflected here in Westwind.Globalization, documentation, tests and sample code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants