Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple Silicon CI Resource Class #434

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Apple Silicon CI Resource Class #434

wants to merge 2 commits into from

Conversation

eliotw1
Copy link
Contributor

@eliotw1 eliotw1 commented Aug 15, 2023

@eliotw1 eliotw1 changed the title Apple Silicon M1 CI Resource Class Apple Silicon CI Resource Class Aug 15, 2023
@raizlabs-oss-bot
Copy link
Collaborator

Danger has errored

[!] Invalid Dangerfile file: �[31mError creating your coverage report - see the log above�[0m

 #  from Dangerfile:27
 #  -------------------------------------------
 #  
 >  xcov.report(
 #    project: "#{src_root}/BonMot.xcodeproj",
 #  -------------------------------------------

Generated by 🚫 Danger

@eliotw1 eliotw1 force-pushed the eliotw1/m-1-ci branch 7 times, most recently from f2f9363 to 13922ce Compare August 15, 2023 22:54
Based on https://circleci.com/blog/m1-mac-resource-class/

Xcode 14

...for a valid build image.

config.yml Ruby 2.6

Manual Ruby Install & Xcode 14.5

Just to see

Add Space

Quote me on that

Corrected

Ruby 3.0.6

Specify Xcode 13.4.1

Conditional?

Extra Bashful

Cleanup

Revert "Cleanup"

This reverts commit d5ef74e.

Can this be separate?

Version Trim

Sourcery

Chruby only

Try Less

Pruned

Bundle Update

Xcode 13 issue

Split Route

Use your words
# Ensure ruby-build is up-to-date
brew update && brew upgrade ruby-build

# Check if Ruby 3.0.6 is already installed; if not, install it
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We reference Ruby 3.0.6 a bunch of times in this file and the next. Can we use a standard .ruby-version file in the project, which rbenv will respect, so we don't need to manually reference it everywhere?

@ZevEisenberg
Copy link
Collaborator

ZevEisenberg commented Aug 16, 2023

One of the failures we're seeing is surrounding a test we have for the error messages we get from XMLParser. When it encounters an error, we try to be helpful and supply the column and line in the XML string where the error occurred. We do that by looking at the column and line where the parser is when we log the error. In Xcode 14 and aligned releases, the column number just seems to be wildly wrong. Here's someone who saw something similar: https://stackoverflow.com/questions/7137322/nsxmlparser-column-number-is-wrong

@@ -109,14 +115,47 @@ executors:
shell: /bin/bash --login -eo pipefail
xcode-13:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can safely ditch Xcode 13 and just test 14.

brew update && brew upgrade ruby-build

# Check if Ruby 3.0.6 is already installed; if not, install it
if ! rbenv versions | grep -q 3.0.6; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might be able to avoid a lot of (all of?) this script because it looks like Circle has support for switching between modern rubies: https://circleci.com/docs/testing-ios/#using-ruby

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants