Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace for CI #439

Draft
wants to merge 56 commits into
base: master
Choose a base branch
from

Conversation

AgapovOne
Copy link

No description provided.

…p and do not have the time or energy to maintain it. If there is a simpler way to do this in future, we could consider adding it back.
…ize package while keeping example project usable.
…res happened, and to make error reporting simpler and easier to test.
@AgapovOne
Copy link
Author

Seems like circle ci just blocked me :)

@ZevEisenberg
Copy link
Collaborator

Haha oops. I forget what I was doing on my other branch (it looks like you're using some of it though?), but I was thinking of moving over to GitHub actions. Also dropping old Xcode versions; too much of a headache, and folks are usually better about upgrading these days.

@AgapovOne
Copy link
Author

Yes, I just used your work and wanted to try more.

I see that issue is Resources with swift test command. It just breaks with bundle retrieval of images.

I will try to convert to GitHub actions

@ZevEisenberg
Copy link
Collaborator

Thanks! I definitely regret putting so much image stuff in this project; what a headache! I'm also tinkering with what I hope could become BonMot's successor: a new library that allows customized styling of AttributedString via Markdown using the same underlying markdown stack as Foundation is using.

@AgapovOne AgapovOne force-pushed the fix-xcode-15-warnings-retry branch from add0dd8 to c100795 Compare July 20, 2024 09:10
@AgapovOne
Copy link
Author

I did a github actions integration. Here is a build: https://github.com/AgapovOne/BonMot/actions/runs/10029740863?pr=1

  • Added xcresult of tests
  • Added upload artifacts step for easier investigation

Now I don't get why so many tests are broken. Tried to fix bundle issues with image retrieval on macOS, failed.

Then tried to see what happened with dynamic type on tvOS. Seems like Apple just removed any dynamic type support and they have only Large now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants