Skip to content

Commit

Permalink
Revert "[RISCV] Remove dead early exit in performCombineVMergeAndVOps…
Browse files Browse the repository at this point in the history
…. NFC"

This reverts commit cee60a8.

This change is not NFC because there is also an additional check for
isImplicitDef in the branch above.
  • Loading branch information
lukel97 committed Jan 17, 2024
1 parent cee60a8 commit 5e8def2
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3545,6 +3545,9 @@ bool RISCVDAGToDAGISel::performCombineVMergeAndVOps(SDNode *N) {

if (IsMasked) {
assert(HasTiedDest && "Expected tied dest");
// The vmerge instruction must be TU.
if (isImplicitDef(Merge))
return false;
// The vmerge instruction must have an all 1s mask since we're going to keep
// the mask from the True instruction.
// FIXME: Support mask agnostic True instruction which would have an
Expand Down

0 comments on commit 5e8def2

Please sign in to comment.