-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make VoiceChatService's documentation clearer #866
Merged
Merged
+24
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
engine reference
Changes the Engine API Reference documentation
label
Oct 17, 2024
rbxphogen
requested review from
MagiMaster,
matthewzhang-rbx,
fumminger and
sofiaconmorales
October 17, 2024 15:47
rbxphogen
commented
Oct 17, 2024
Co-authored-by: matthewzhang-rbx <[email protected]>
Co-authored-by: matthewzhang-rbx <[email protected]>
rbxphogen
commented
Oct 18, 2024
fumminger
previously approved these changes
Oct 18, 2024
IgnisRBX
reviewed
Oct 18, 2024
IgnisRBX
reviewed
Oct 18, 2024
IgnisRBX
reviewed
Oct 18, 2024
IgnisRBX
reviewed
Oct 18, 2024
IgnisRBX
reviewed
Oct 18, 2024
rbxphogen
commented
Oct 18, 2024
rbxphogen
commented
Oct 18, 2024
rbxphogen
commented
Oct 18, 2024
rbxphogen
commented
Oct 18, 2024
Co-authored-by: rbxphogen <[email protected]>
rbxphogen
commented
Oct 18, 2024
Co-authored-by: rbxphogen <[email protected]>
Co-authored-by: rbxphogen <[email protected]>
Co-authored-by: rbxphogen <[email protected]>
IgnisRBX
reviewed
Oct 18, 2024
IgnisRBX
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds detailed descriptions of
UseAudioApi
andEnableDefaultVoice
– revise the summary.Checks
By submitting your pull request for review, you agree to the following: