Upgrade rs-consul to latest http, hyper, opentelemetry #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhixinwen
reviewed
Jun 25, 2024
| @@ -160,7 +166,12 @@ pub struct Config { | |||
|
|
|||
| /// The hyper builder for the internal http client. | |||
| #[serde(skip)] | |||
| pub hyper_builder: hyper::client::Builder, | |||
| #[serde(default = "default_builder")] | |||
| pub hyper_builder: hyper_util::client::legacy::Builder, | |||
There was a problem hiding this comment.
what is the right way to get rid of legacy?
There was a problem hiding this comment.
There is no replacement at the moment. The client has some issues which is why it has been moved out of hyper to hyper-util. A new client will be built at some point.
zhixinwen
approved these changes
Jul 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are we solving?
hyper, http have all released 1.0
How are we solving the problem?
Let's upgrade them all.
This is a breaking change.
Closes #42
Checks
Please check these off before promoting the pull request to non-draft status.